English > Scripts and Templates

AllRovi movie script

<< < (3/26) > >>

Ivek23:

--- Quote ---This is now testing that might find a solution to the Role there because I leave this <td> and this <dd>, but I can not find solution how to remove this.
--- End quote ---

Maybe someone succeeds or help would be welcomed by Nostra.

Ivek23:

--- Quote ---Thanks very much for your work on this, Ivek. I'm happy I've my Reviews back.
--- End quote ---
Rick.ca also thank you for the help that the script works better.


--- Quote ---I wasn't expecting you to incorporate all my changes, having assumed we would need to maintain our separate versions. I now see that should not be necessary. Where you've used a custom field for something I don't use, I can just ignore it. Where you've used a standard field I get from elsewhere, I can turn it off in my Overwrite fields settings. The only real conflicts are where we treat the actual data differently (e.g., Description). In the attached version, I've added a RICK_CA := True option and then separated my modifications using if RICK_CA then...
--- End quote ---

I hope you don 't mind if I added your changes and update the script, but in a good and useful purpose to do better functioning script as well as any other potential users, so I have a proposal to attach your name as a co-author of the script.  Given options
--- Quote ---RICK_CA := True option and then separated my modifications using if RICK_CA then...
--- End quote ---
this is a very good idea


--- Quote ---So unless you plan to do something very unusual, I'm confident we can share the same script. We can use the same technique to add options other users might want.
--- End quote ---
Also true


--- Quote ---Having said that, it's still a PITA when we're both making changes at the same time—as we are today. I'm hoping you won't mind once again incorporating my changes. Or if you prefer, I'll merge the two after you've finished with your Cast & Crew addition. That should be easy if that's all you've changed since version 3.
--- End quote ---

I have nothing against it, even it would be to merge both versions into a single script version to this version would then also be added as an official in the Download section, that would not upset the other two different AllRovi script version, AllMovie script is (would be well placed in the archive or the end of the Download section in the part where there are also other tools, in particular, that at times when he needs it, as I have now, when I worked AllRovi Script ) are not removed because it would certainly come in handy when someone at work was like a new script, I hope you agree with this interpretation.

BTW:
With your permission, these added as a co-author of the script.

Ivek23:
Rick.ca in Review I made a small change
instead of TmpStr3

--- Code: ---if RICK_CA then
AddCustomFieldValueByName('Review', TmpStr2 + #13 + '—' + TmpStr3)
 else
AddCustomFieldValueByName('Review',  '  ~~  ' + TmpStr4 + '  ~~  ' + #13 + TmpStr2 + #13 + ' -  ' +   );

--- End code ---

is TmpStr5

--- Code: ---if RICK_CA then
AddCustomFieldValueByName('Review', TmpStr2 + #13 + '—' + TmpStr3)
 else
AddCustomFieldValueByName('Review',  '  ~~  ' + TmpStr4 + '  ~~  ' + #13 + TmpStr2 + #13 + ' -  ' + TmpStr5 );

--- End code ---

at the end Review write the correct information Who is (the word by) the author of Review text.

rick.ca:

--- Quote from: Ivek23 on July 11, 2011, 07:31:49 pm ---I have nothing against it, even it would be to merge both versions into a single script version to this version would then also be added as an official in the Download section...
--- End quote ---

I think it would be better if the Download section had only one script per data source, and included only scripts and data sources that currently work. That's what most users expect to find there. Old, prior version and defunct scripts are still or can be available as attachments to topics like this one—where their current status and purpose can be explained. It would be okay if they were in a separate "Retired Scripts" section, but I doubt nostra would want to maintain such a thing. And users interested in those scripts would still need to find the topic that explains them.


--- Quote ---With your permission, these added as a co-author of the script.
--- End quote ---

Yes. I look forward to your latest version. I've haven't attempted to add your latest changes (addition of Cast & Crew) to my own. I'd rather just review what you've done and suggest changes to that.

Ivek23:

--- Quote from: rick.ca on July 11, 2011, 08:50:47 pm ---Yes. I look forward to your latest version. I've haven't attempted to add your latest changes (addition of Cast & Crew) to my own. I'd rather just review what you've done and suggest changes to that.

--- End quote ---

Yes

Cast & Crew  I did what was in my power, the result is visible when the data transfer info.

Notice:
Adding in the first post new AllRovi Script Version 0.1.0.4

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version