Author Topic: Probable bug in xml-parser of PVD (skin templates)  (Read 1307 times)

0 Members and 1 Guest are viewing this topic.

Offline goddert

  • User
  • ***
  • Posts: 39
    • View Profile
Probable bug in xml-parser of PVD (skin templates)
« on: March 13, 2012, 10:08:39 pm »
Hello,

I have some problems with a probable bug in the skin templates (xml). The bug occurs using comments in xml.
Putting comments before markup (not inside!) changes the behaviour of the tags in the visualization.
Until now I found one example with the tag videostreamlabel and another with the tag videodatalabel. Putting a comment before the former tag the comment changes its alignment in the visualization. Putting a comment before the latter one makes vanish completely the data which should be shown.

Included you find a working example and a not working example to compare the effect.
(Tip: delete first comment and see the effect then delete the second comment and see the second effect)

It would be nice if someone could verify this.

Thanks

Example (not working - comments at wrong place)
Code: [Select]
<?xml version="1.0" encoding="utf-8"?>
<xml>
    <pvd_skin_movie>
        <skinname>PVD Midnight bug</skinname>
        <version>0.9.0.0</version>
        <author>goddert</author>
        <description>Color skin</description>
        <preview>pvd_movie_midnight.png</preview>
        <!-- section with filepath, (quality, duration, size, mediatype, medialabel, medialocation), videostreamdata, audiostreamdata, subtitle and feature rows -->
<section>
<!-- row with videostreamdata column -->
<row>
<!-- column with videostreamdata expandable section -->
<column>
<!-- expandable section with videostreamdata rows -->
<expandsection>
<!-- row with videostreamlabel and videodatalabel columns -->
<row>
<!-- don't comment here; corrupts alignment of label -->
<column>
<videostreamlabel></videostreamlabel>
</column>
<!-- don't comment here; makes vanish data -->
<column>
<videodatalabel></videodatalabel>
</column>
</row>
<row>
<column>
<fieldlabel field="videocodec"></fieldlabel>
<videocodec/>
</column>
</row>
</expandsection>
</column>
</row>
</section>
    </pvd_skin_movie>
</xml>

Example (working - no comments at wrong place)
Code: [Select]
<?xml version="1.0" encoding="utf-8"?>
<xml>
    <pvd_skin_movie>
        <skinname>PVD Midnight nobug</skinname>
        <version>0.9.0.0</version>
        <author>goddert</author>
        <description>Color skin</description>
        <preview>pvd_movie_midnight.png</preview>
        <!-- section with filepath, (quality, duration, size, mediatype, medialabel, medialocation), videostreamdata, audiostreamdata, subtitle and feature rows -->
<section>
<!-- row with videostreamdata column -->
<row>
<!-- column with videostreamdata expandable section -->
<column>
<!-- expandable section with videostreamdata rows -->
<expandsection>
<!-- row with videostreamlabel and videodatalabel columns -->
<row>
<column>
<videostreamlabel></videostreamlabel>
</column>
<column>
<videodatalabel></videodatalabel>
</column>
</row>
<row>
<column>
<fieldlabel field="videocodec"></fieldlabel>
<videocodec/>
</column>
</row>
</expandsection>
</column>
</row>
</section>
    </pvd_skin_movie>
</xml>

Offline goddert

  • User
  • ***
  • Posts: 39
    • View Profile
Re: Probable bug in xml-parser of PVD (skin templates)
« Reply #1 on: March 14, 2012, 08:59:15 am »
I did some further test and the problem seems not to be tag related but a general problem of the column tag in expandable sections like <expandsection> or <astreams>. Every comment before a <column> in one of these sections corrupts the alignment of the column or the data inside which should show up but doesn't.

Offline goddert

  • User
  • ***
  • Posts: 39
    • View Profile
Re: Probable bug in xml-parser of PVD (skin templates)
« Reply #2 on: March 17, 2012, 07:06:08 pm »
Not only expandable sections. All kind of sections. It's very annoying not being able to put comments while one has to fear the layout of a skin could be destroyed.  :(
Can this be resolved with next version, please.

 

anything