Author Topic: AdultDVDEmpire script  (Read 18810 times)

0 Members and 1 Guest are viewing this topic.

Offline joc

  • Member
  • *
  • Posts: 10
    • View Profile
Re: AdultDVDEmpire script
« Reply #20 on: August 04, 2012, 02:12:58 am »
Hi,
first of a big THX for the work you put in this.
But somehow the script is still (or maybe again) broken for me.
Especially the studio and year fields often end up in a huge mess (containing a lot of html code etc).

First i thought about fixing it in your script but then i decided to start from scratch to learn some pascal.   :P
When looking through the source you might notice i'm actually a java dev - so my code style is probably not very "pascal like".   :-[

You're right it's broken again. I don't use that script very much, so I didn't notice.

Your script works, that's what matters 8), - and I'm no programmer myself, so i don't mind if it's not "pascal-like"  ;D

Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #21 on: August 04, 2012, 04:41:24 pm »
i converted my script to pascal style (according to http://edn.embarcadero.com/article/10280 and the other scripts) so others can pick this up.

furthermore i extended the script so everything available on ADE should now be parsed.
the following fields are handled: title, studio, year, poster (front and back), tagline, description, actors, directors, producers, genre, features, mpaa, rating, release date, duration

[attachment deleted by admin]
« Last Edit: August 04, 2012, 04:43:47 pm by GazonkFoo »

Offline joc

  • Member
  • *
  • Posts: 10
    • View Profile
Re: AdultDVDEmpire script
« Reply #22 on: August 04, 2012, 05:10:57 pm »
i converted my script to pascal style (according to http://edn.embarcadero.com/article/10280 and the other scripts) so others can pick this up.

furthermore i extended the script so everything available on ADE should now be parsed.
the following fields are handled: title, studio, year, poster (front and back), tagline, description, actors, directors, producers, genre, features, mpaa, rating, release date, duration

Impressive work, thanks :) (Let's hope they don't make any more major changes >:()

Offline oenghus

  • Member
  • *
  • Posts: 10
    • View Profile
Re: AdultDVDEmpire script
« Reply #23 on: August 14, 2012, 04:12:15 am »
i converted my script to pascal style (according to http://edn.embarcadero.com/article/10280 and the other scripts) so others can pick this up.

furthermore i extended the script so everything available on ADE should now be parsed.
the following fields are handled: title, studio, year, poster (front and back), tagline, description, actors, directors, producers, genre, features, mpaa, rating, release date, duration

Thanks for taking this on.  :)

I discovered a couple of issues as I don't get any posters and the description isn't complete and has <p> tag at the beginning.

Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #24 on: August 14, 2012, 06:22:59 pm »
Thanks for pointing this out - they indeed changed something in the description.
Find attached the new script where this should be fixed.

However i cannot reproduce the poster not loading stuff :(
Can you please tell me on which movie(s) this happens?

[attachment deleted by admin]

Offline oenghus

  • Member
  • *
  • Posts: 10
    • View Profile
Re: AdultDVDEmpire script
« Reply #25 on: August 15, 2012, 12:10:05 am »
I'm using PVD 1.0.2.3.

I can't get posters for any film from Adult DVD Empire but try:

    http://www.adultdvdempire.com/1609649/countdown-porn-movies.html

I created a new database and then added the title. When I import using your latest script I get everything except the posters.

If I go back to version  0.1.1.1 of the script and recompile, I get the poster.

Thanks

Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #26 on: August 15, 2012, 12:43:12 am »
Just tried the movie in PVD 0.9.9.21 and 1.0.2.3
The posters (front & back) work in 0.9 and as you said won't load in 1.0 :(

I don't have a clue why this is broken in the new version, so maybe one of the devs could help me out.

This is the affected piece of code (line 148 in my script):
Code: [Select]
//Poster (Front & Back)
  PosterURL := HTMLValue(HTML, 0, 0, '<div id="Boxcover"><a href="', '"');
  BackPosterURL := StringReplace(PosterURL, 'h.jpg', 'bh.jpg', False, True, False);
  if (PosterURL <> '') and (BackPosterURL <> PosterURL) then
  begin
    LogMessage('poster: '+ PosterURL +', back: '+ BackPosterURL);
    AddImageURL(0, PosterURL);
    AddImageURL(0, BackPosterURL);
  end else
    LogMessage('poster not found');

The log output shows that AddImageURL is in fact called:
Code: [Select]
poster: http://cdn3c.adultempire.org/products/49/1609649h.jpg, back: http://cdn3c.adultempire.org/products/49/1609649bh.jpg

Offline oenghus

  • Member
  • *
  • Posts: 10
    • View Profile
Re: AdultDVDEmpire script
« Reply #27 on: August 15, 2012, 02:17:11 am »
I've tried another script that uses AddImageURL and that doesn't save the poster either but I know that it used to work before I upgraded from 0.9.9.21.

Thanks for investigating.

Offline oenghus

  • Member
  • *
  • Posts: 10
    • View Profile
Re: AdultDVDEmpire script
« Reply #28 on: August 18, 2012, 02:06:48 am »
Just tried the movie in PVD 0.9.9.21 and 1.0.2.3
The posters (front & back) work in 0.9 and as you said won't load in 1.0 :(

I don't have a clue why this is broken in the new version, so maybe one of the devs could help me out.

I've reverted back to 0.9.9.21 until the issue with AddImageURL is fixed.  :(

I may move the text that you add for the Tagline into the Description as I use the Tagline for something else.

Thanks for all your work. 8)


Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #29 on: August 18, 2012, 12:14:43 pm »
Oh wait you don't have to go back to 0.9.9.21.
Find attached a version which only downloads the front cover (so there's no need for AddImageURL).

[attachment deleted by admin]

Offline cooltj

  • Member
  • *
  • Posts: 1
    • View Profile
Re: AdultDVDEmpire script
« Reply #30 on: August 25, 2012, 01:53:49 pm »
Hello. Can someone fix the old script "adultdvdempire_person.psf"?

[attachment deleted by admin]

Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #31 on: August 26, 2012, 12:51:36 am »
Find attached the new person script.

Handled values:
Name, Photo, Altnames, Birthplace, Birthday, Comment

The Biography field is filled with weight, height, eye color, measurements, hair color and ethnicity.

[attachment deleted by admin]

Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #32 on: August 27, 2012, 07:36:17 pm »
I would like to publish the new scripts to the automatic update system but before i can do that i need some more testers.
So it would be really helpful if everyone could download the scripts from my last two posts and give me some feedback.

Thanks guys!!


btw if anyone needs a PVD script feel free to drop me a PM ;)

Offline AimHere

  • Power User
  • ****
  • Posts: 202
    • View Profile
Re: AdultDVDEmpire script
« Reply #33 on: August 28, 2012, 02:05:38 pm »
Hey Gazonk,

It's great that you've decided to pick this up! For awhile, I was trying to maintain the original ADE script (updating for ADE website changes)... but not having written it myself, I always felt like I was just stumbling in the dark. ;D

First joc pitches in, and now you. Thanks!!!

Aimhere

Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #34 on: August 28, 2012, 06:05:15 pm »
Hi AimHere,

i did my best to clean up the code and i think it should be pretty easy to understand whats going on now 8)
so feel invited to contribute (but of course i will also maintain it) ;)

btw what do you guys think about moving this and other scripts/plugins to a project hosting site (e.g. google code, github, sourceforge)?
not having the code under version control makes me nervous.

Offline Ivek23

  • Global Moderator
  • *****
  • Posts: 1899
    • View Profile
Re: AdultDVDEmpire script
« Reply #35 on: August 28, 2012, 07:30:23 pm »
btw what do you guys think about moving this and other scripts/plugins to a project hosting site (e.g. google code, github, sourceforge)?
not having the code under version control makes me nervous.

There are therefore versions and updates. You can then also final or updated version added to for the auto-update system.

We'll see, what he says to this Nostra or Moderator.
Ivek23
Win 7 32bit, 64bit   PVD v0.9.9.21


Offline rick.ca

  • Global Moderator
  • *****
  • Posts: 3241
  • "I'm willing to shoot you!"
    • View Profile
Re: AdultDVDEmpire script
« Reply #36 on: August 28, 2012, 10:00:56 pm »
not having the code under version control makes me nervous.

Why? It's a simple script. It's easy enough to apply your own version control by assigning version numbers and maintaining a change log in the script. Ivek and I worked together on the AllRovi script, and had no difficulty through many development versions and several bug fix versions after release to the auto-update system.

If the project is complicated and/or there are more than a few people working on, you may find a more formal form of version control beneficial. But it shouldn't be assumed to be necessary in all cases.

Offline GazonkFoo

  • Member
  • *
  • Posts: 17
    • View Profile
Re: AdultDVDEmpire script
« Reply #37 on: August 28, 2012, 10:33:32 pm »
Well it's much easier to follow changes and track issues than in a forum.
Keeping changelogs in the source code is something i really dislike.

Ok i must admit i normaly work on larger scale projects and i'm actually a fulltime developer but for me there's no downside of this. I don't see how more than two people can work on anything without a VCS (it's already hard for two to work in parallel).

Setting up a project on any of the hosting sites is a matter of seconds.

Offline rick.ca

  • Global Moderator
  • *****
  • Posts: 3241
  • "I'm willing to shoot you!"
    • View Profile
Re: AdultDVDEmpire script
« Reply #38 on: August 28, 2012, 11:32:06 pm »
I don't know how I can be more clear. Do what you please. If you're working with another developer, that person will no doubt agree. It might even be a good idea for two or more amateurs working on a project. But the method doesn't need to be imposed on anyone.

Offline AimHere

  • Power User
  • ****
  • Posts: 202
    • View Profile
Re: AdultDVDEmpire script
« Reply #39 on: October 07, 2013, 06:23:10 pm »
I think the ADE script on the Downloads page ought to be replaced with GazonkFoo's version.

I had been using the old version (0.1.1.something) but ADE made another change to their HTML that broke the old script. Basically, the script was searching for a tag that delimits some of the info it extracts from the webpages, but ADE started using two variations of the tag, so the script went into an infinite loop. :P I figured out how to fix the old script, but it's really just a band-aid. GazonkFoo's version handled the same search without any problems, so why bother with the old one anymore...

aimhere

 

anything